-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: PrivateLink support #169
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsbroks
reviewed
Jan 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing. Just get back to me on the root and Ill approve
Co-authored-by: Justin Brooks <jsbroks@gmail.com>
jsbroks
approved these changes
Jan 31, 2024
jsbroks
pushed a commit
that referenced
this pull request
Jan 31, 2024
## [4.2.0](v4.1.2...v4.2.0) (2024-01-31) ### Features * PrivateLink support ([#169](#169)) ([10cc72f](10cc72f))
This PR is included in version 4.2.0 🎉 |
This was referenced Feb 5, 2024
zacharyblasczyk
added a commit
that referenced
this pull request
Feb 15, 2024
* Feat: Private-link * tfdocs update --------- Co-authored-by: Justin Brooks <jsbroks@gmail.com>
zacharyblasczyk
pushed a commit
that referenced
this pull request
Feb 15, 2024
## [4.2.0](v4.1.2...v4.2.0) (2024-01-31) ### Features * PrivateLink support ([#169](#169)) ([10cc72f](10cc72f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a p
rivate_link module
to enable to automatic setting up AWS PrivateLink.The key variable is
private_link_allowed_account_ids
, which triggers the module only when a list of allowed AWS account IDs is provided.Other crucial variables include
namespace
for resource naming (and the limit of LB's names),network_private_subnets
for specifying VPC private subnets anddeletion_protection
for enabling deletion protection.