Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PrivateLink support #169

Merged
merged 7 commits into from
Jan 31, 2024
Merged

feat: PrivateLink support #169

merged 7 commits into from
Jan 31, 2024

Conversation

zacharyblasczyk
Copy link
Contributor

This pull request introduces a private_link module to enable to automatic setting up AWS PrivateLink.

The key variable is private_link_allowed_account_ids, which triggers the module only when a list of allowed AWS account IDs is provided.

Other crucial variables include namespace for resource naming (and the limit of LB's names), network_private_subnets for specifying VPC private subnets and deletion_protection for enabling deletion protection.

@zacharyblasczyk zacharyblasczyk requested a review from gls4 as a code owner January 25, 2024 21:03
@zacharyblasczyk zacharyblasczyk requested a review from a team January 25, 2024 21:03
@zacharyblasczyk zacharyblasczyk changed the title Feat: PrivateLink support feat: PrivateLink support Jan 25, 2024
Copy link
Member

@jsbroks jsbroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing. Just get back to me on the root and Ill approve

@zacharyblasczyk zacharyblasczyk enabled auto-merge (squash) January 31, 2024 17:17
@zacharyblasczyk zacharyblasczyk merged commit 10cc72f into main Jan 31, 2024
5 checks passed
@zacharyblasczyk zacharyblasczyk deleted the feat/private-link-support branch January 31, 2024 17:18
jsbroks pushed a commit that referenced this pull request Jan 31, 2024
## [4.2.0](v4.1.2...v4.2.0) (2024-01-31)

### Features

* PrivateLink support ([#169](#169)) ([10cc72f](10cc72f))
@jsbroks
Copy link
Member

jsbroks commented Jan 31, 2024

This PR is included in version 4.2.0 🎉

zacharyblasczyk added a commit that referenced this pull request Feb 15, 2024
* Feat: Private-link

* tfdocs update

---------

Co-authored-by: Justin Brooks <jsbroks@gmail.com>
zacharyblasczyk pushed a commit that referenced this pull request Feb 15, 2024
## [4.2.0](v4.1.2...v4.2.0) (2024-01-31)

### Features

* PrivateLink support ([#169](#169)) ([10cc72f](10cc72f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants