removed create_kms boolean and updated conditions

wandb · Feb 28, 2024 · 3e0a0a9 · 3e0a0a9
1 parent 239ef06
commit 3e0a0a9
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 13 deletions.
diff --git a/main.tf b/main.tf
@@ -10,10 +10,9 @@ module "kms" {
 locals {
 
   default_kms_key = module.kms.key.arn
-
-  s3_kms_key_arn= var.create_kms ? local.default_kms_key : length(var.bucket_kms_key_arn)> 0 ? var.bucket_kms_key_arn : local.default_kms_key
-  db_kms_key_arn = var.create_kms ?  local.default_kms_key: length(var.db_kms_key_arn)> 0  ? var.db_kms_key_arn : local.default_kms_key
-  database_performance_insights_kms_key_arn = var.create_kms ?  local.default_kms_key: length(var.database_performance_insights_kms_key_arn)> 0  ? var.database_performance_insights_kms_key_arn : local.default_kms_key
+  s3_kms_key_arn= length(var.bucket_kms_key_arn)> 0 ? var.bucket_kms_key_arn : local.default_kms_key
+  db_kms_key_arn = length(var.db_kms_key_arn)> 0 ? var.db_kms_key_arn : local.default_kms_key
+  database_performance_insights_kms_key_arn = length(var.database_performance_insights_kms_key_arn)> 0  ? var.database_performance_insights_kms_key_arn : local.default_kms_key
   use_external_bucket = var.bucket_name != ""
   use_internal_queue  = local.use_external_bucket || var.use_internal_queue
 }

diff --git a/outputs.tf b/outputs.tf
@@ -48,7 +48,7 @@ output "internal_app_port" {
 }
 
 output "kms_key_arn" {
-  value       = local.kms_key_arn_generic
+  value       = local.default_kms_key
   description = "The Amazon Resource Name of the KMS key used to encrypt data at rest."
 }
 

diff --git a/variables.tf b/variables.tf
@@ -362,7 +362,12 @@ variable "bucket_name" {
 variable "bucket_kms_key_arn" {
   type        = string
   description = "The Amazon Resource Name of the KMS key with which S3 storage bucket objects will be encrypted."
-  default     = ""
+  default     = null
+  validation {
+    # regex(...) fails if it cannot find a match
+    condition     = can(regex("^arn:aws:kms:*:*"))
+    error_message = "Invalid value for bucket kms ARN"
+  }
 }
 
 ##########################################
@@ -398,13 +403,12 @@ variable "other_wandb_env" {
 # New Vars for Encryption                #
 ##########################################
 
-variable "create_kms" {
-  type = bool
-  default = true
-
-}
 variable "db_kms_key_arn" {
   type    = string
-  default = ""
-
+  default = null
+  validation {
+    # regex(...) fails if it cannot find a match
+    condition     = can(regex("^arn:aws:kms:*:*"))
+    error_message = "Invalid value for db kms ARN"
+  }
 }