-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added internal ingress #102
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
3b3aa0e
Added internal ingress
e72410f
Added internal ingress
cab1a55
removed tpl file
d391db0
removed tpl file
588f449
removed tpl file
007bb3b
Update Chart.yaml
amanpruthi e20e55b
resolving comments
amanpruthi fda965a
Merge branch 'main' into aman/issue-95
amanpruthi 34370b5
fixed lint
2b93a56
renamed private ingress
70c9c17
added files in _ingress.tpl
ecfe4ec
fixed tpl file
5fd0e41
fixed tpl file
dce421d
tpl file changes
75f2609
updated helm
8373f56
fixed ingress tpl
5fd2640
resolved comment
482aa85
Merge branch 'main' into aman/issue-95
amanpruthi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -104,6 +104,7 @@ global: | |
|
||
ingress: | ||
install: true | ||
create: true | ||
nameOverride: "" | ||
defaultBackend: "app" | ||
annotations: {} | ||
|
@@ -116,6 +117,21 @@ ingress: | |
provider: "" | ||
server: https://acme-v02.api.letsencrypt.org/directory | ||
email: support@wandb.com | ||
secondary: | ||
create: false | ||
install: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unused? |
||
nameOverride: "" | ||
defaultBackend: "app" | ||
annotations: {} | ||
labels: {} | ||
tls: [] | ||
additionalHosts: [] | ||
class: "" | ||
issuer: | ||
create: false | ||
provider: "" | ||
server: https://acme-v02.api.letsencrypt.org/directory | ||
email: support@wandb.com | ||
Comment on lines
+132
to
+134
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do these need to be wired up? |
||
|
||
parquet: | ||
install: true | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?