-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new parameter #85
Conversation
Hi @Psychosynthesis ! Thank you for your interest in improving the timer plugin. Please do note that PRs need to be created with adequate tests added for the features they introduce/update. Additionally could you please explain a real world scenario where starting timer in a hidden way would be useful? I just want to make sure we dont introduce something that could ve been entirely handled via |
Hi! |
Well, in general, I could come up with a couple more scenarios, of course ... ... but I will say shortly. In my particular case, it seemed to me that using your library was simply more convenient than setInterval \ setTimeout, but I did not need the output to the block. As a result, I had to add style to hide the block with the timer. |
It sure makes sense. I think it’s a good thing to add. Please add few tests to your PR to cover your feature. |
Sorry, I believe that I do not fully understand how testing works in your project. Also, I see that you are using grunt for this. I guess I can not finish the job due to lack of experience. |
Dont worry, I understand. I ll add the tests later. For now please bump the package minor version as part of this PR. Basically make it |
@Psychosynthesis i m merging this in. I ll update the package and add tests. |
Nice, thank you |
Hello.
Sometimes it is very convenient to be able to turn off the display of the timer on the page.