Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not checking actual value numbers for tensor parameters in TF2 tests #109

Closed
khatchad opened this issue Nov 30, 2023 · 0 comments · Fixed by ponder-lab/ML#60 or #110
Closed

Not checking actual value numbers for tensor parameters in TF2 tests #109

khatchad opened this issue Nov 30, 2023 · 0 comments · Fixed by ponder-lab/ML#60 or #110
Assignees
Labels
bug Something isn't working testing Related to test code or test input

Comments

@khatchad
Copy link
Collaborator

We are only checking the length of the expected array.

assertEquals(expectedTensorParameterValueNumbers.length, actualValueNumberSet.size());
Arrays.stream(expectedTensorParameterValueNumbers)
.forEach(ev -> actualValueNumberSet.contains(ev));

@khatchad khatchad added bug Something isn't working testing Related to test code or test input labels Nov 30, 2023
@khatchad khatchad self-assigned this Nov 30, 2023
khatchad added a commit to ponder-lab/ML that referenced this issue Nov 30, 2023
@khatchad khatchad linked a pull request Nov 30, 2023 that will close this issue
khatchad added a commit to ponder-lab/ML that referenced this issue Dec 1, 2023
@khatchad khatchad mentioned this issue Dec 1, 2023
khatchad added a commit to ponder-lab/ML that referenced this issue Dec 1, 2023
We know this now as a result of wala#109.
khatchad added a commit that referenced this issue Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Related to test code or test input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant