fix: improve dependencies handling of @libp2p in pnpm #2200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
pnpm
gets confused withpeerDependencies
js-waku
has and misses@libp2p/bootstrap
package.Solution
This PR removes
peerDependencies
as they are makingpnpm
misbehave with how it resolves dependencies.There is no problem with
pnpm
as I see, it's more of a problem withpeerDeps
getting out of sync with other deps whilelibp2p
goes through upgrade.Notes
@waku/sdk
is published under0.0.30-1c0c5ee.0
version with this fix.As for
peerDependencies
- removing them to prevent any confusion. Let's add them back once requested by consumers.