Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade node to LTS 20 #2110

Merged
merged 2 commits into from
Aug 23, 2024
Merged

chore: upgrade node to LTS 20 #2110

merged 2 commits into from
Aug 23, 2024

Conversation

danisharora099
Copy link
Collaborator

Problem

Node upgraded LTS from 18 to 20

@danisharora099 danisharora099 changed the title chore: upgrade nodejs to new LTS 20 chore: upgrade nodejs to LTS 20 Aug 23, 2024
Copy link

github-actions bot commented Aug 23, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 86.5 KB (-0.11% 🔽) 1.8 s (-0.11% 🔽) 3.4 s (+31.46% 🔺) 5.1 s
Waku Simple Light Node 154.2 KB (+0.05% 🔺) 3.1 s (+0.05% 🔺) 2 s (-33.39% 🔽) 5.1 s
ECIES encryption 22.83 KB (0%) 457 ms (0%) 798 ms (-39.26% 🔽) 1.3 s
Symmetric encryption 22.33 KB (0%) 447 ms (0%) 1.2 s (-0.4% 🔽) 1.7 s
DNS discovery 72.27 KB (+0.01% 🔺) 1.5 s (+0.01% 🔺) 2.2 s (-28.48% 🔽) 3.7 s
Peer Exchange discovery 73.75 KB (-0.06% 🔽) 1.5 s (-0.06% 🔽) 2.1 s (-5.06% 🔽) 3.5 s
Local Peer Cache Discovery 67.57 KB (+0.01% 🔺) 1.4 s (+0.01% 🔺) 2 s (-17.68% 🔽) 3.4 s
Privacy preserving protocols 38.91 KB (-0.06% 🔽) 779 ms (-0.06% 🔽) 795 ms (-31.37% 🔽) 1.6 s
Waku Filter 81.07 KB (+0.09% 🔺) 1.7 s (+0.09% 🔺) 1.4 s (-51.23% 🔽) 3 s
Waku LightPush 78.59 KB (-0.01% 🔽) 1.6 s (-0.01% 🔽) 2.5 s (+16.63% 🔺) 4.1 s
History retrieval protocols 79.1 KB (+0.1% 🔺) 1.6 s (+0.1% 🔺) 2.6 s (-18.65% 🔽) 4.2 s
Deterministic Message Hashing 7.31 KB (0%) 147 ms (0%) 161 ms (-43.83% 🔽) 307 ms

@danisharora099 danisharora099 marked this pull request as ready for review August 23, 2024 09:52
@danisharora099 danisharora099 requested a review from a team as a code owner August 23, 2024 09:52
@danisharora099 danisharora099 changed the title chore: upgrade nodejs to LTS 20 chore: upgrade node to LTS 20 Aug 23, 2024
Copy link
Collaborator

@weboko weboko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally!

@danisharora099 danisharora099 merged commit 69b6612 into master Aug 23, 2024
11 of 12 checks passed
@danisharora099 danisharora099 deleted the chore/upgrade-node-20 branch August 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants