Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enforce access modifiers #2068

Merged
merged 12 commits into from
Jul 19, 2024
Merged

Conversation

danisharora099
Copy link
Collaborator

This PR adds the @typescript-eslint/explicit-member-accessibility rule in eslint to enforce access modifiers

@danisharora099 danisharora099 marked this pull request as ready for review July 17, 2024 11:06
@danisharora099 danisharora099 requested a review from a team as a code owner July 17, 2024 11:06
Copy link

github-actions bot commented Jul 17, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Waku node 183.75 KB (+0.02% 🔺) 3.7 s (+0.02% 🔺) 28.7 s (+8.29% 🔺) 32.4 s
Waku Simple Light Node 183.84 KB (-0.04% 🔽) 3.7 s (-0.04% 🔽) 25 s (-19.55% 🔽) 28.7 s
ECIES encryption 23.12 KB (0%) 463 ms (0%) 8.2 s (+35.41% 🔺) 8.6 s
Symmetric encryption 22.58 KB (0%) 452 ms (0%) 3.3 s (-74.29% 🔽) 3.8 s
DNS discovery 72.49 KB (0%) 1.5 s (0%) 13.2 s (+8.26% 🔺) 14.7 s
Peer Exchange discovery 74.15 KB (0%) 1.5 s (0%) 10.7 s (-20.2% 🔽) 12.2 s
Local Peer Cache Discovery 67.68 KB (0%) 1.4 s (0%) 15.4 s (+9.9% 🔺) 16.7 s
Privacy preserving protocols 38.87 KB (0%) 778 ms (0%) 10.8 s (+0.27% 🔺) 11.6 s
Waku Filter 113.38 KB (+0.07% 🔺) 2.3 s (+0.07% 🔺) 18.1 s (-3.14% 🔽) 20.4 s
Waku LightPush 111.3 KB (0%) 2.3 s (0%) 28.5 s (+51.73% 🔺) 30.7 s
History retrieval protocols 111.78 KB (0%) 2.3 s (0%) 21 s (+38.13% 🔺) 23.2 s
Deterministic Message Hashing 7.29 KB (0%) 146 ms (0%) 2.2 s (+12.02% 🔺) 2.3 s

@danisharora099 danisharora099 force-pushed the chore/enforce-access-modifiers branch from c508949 to 4906433 Compare July 18, 2024 12:15
@danisharora099 danisharora099 merged commit 169a09d into master Jul 19, 2024
10 of 11 checks passed
@danisharora099 danisharora099 deleted the chore/enforce-access-modifiers branch July 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants