Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag to set wss port #297

Merged
merged 1 commit into from
Aug 26, 2022
Merged

feat: add flag to set wss port #297

merged 1 commit into from
Aug 26, 2022

Conversation

richard-ramos
Copy link
Member

@richard-ramos richard-ramos commented Aug 25, 2022 •
edited
Loading

Fixes #275
Adds the flag --websocket-secure-port and its alias --wss-port to allow setting up different ports for websockets and secure websockets.

@richard-ramos richard-ramos requested a review from jakubgs August 25, 2022 21:29
@richard-ramos
Copy link
Member Author

richard-ramos commented Aug 25, 2022 •
edited
Loading

@jm-clius @fryorcraken
We should probably add the same flag to nwaku

jakubgs
jakubgs approved these changes Aug 26, 2022
View reviewed changes
Copy link
Contributor

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@richard-ramos richard-ramos merged commit a1e5b58 into master Aug 26, 2022
@richard-ramos richard-ramos deleted the wss-port branch August 26, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --wss-port to set an specific port for secure websockets
2 participants
@richard-ramos @jakubgs