fix: add peer addresses on expiry if peer is discovered again #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
approved these changes
Jun 17, 2024
This was referenced Jun 18, 2024
39 tasks
This was referenced Jun 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While testing status-im/status-go#5350 after enabling peerExchangeClient, had noticed a good number of peer connection failures happen because of peer addresses expiring.
If a peer is discovered dynamically, its address TTL i set to default value which is 1 hour.
Eventhough the peer is discovered again later, only the ENR is updated in case of a change. This results in addresses being expired and hence failing to connect to these peers with error "no addresses".
ERROR[06-14|15:41:07.989|github.com/waku-org/go-waku/waku/v2/protocol/filter/client.go:405] Failed to subscribe pubSubTopic=/waku/2/rs/16/32 contentTopics=[/waku/1/0x7135123e/rfc26] error="failed to dial: failed to dial 16Uiu2HAkuanZeK281yniUVD9pUMWoBe2MjSknjy5gLB5LuhJj1Bk: no addresses"Changes