-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is it possible to reduce the pull time for : Pull wagoid/commitlint-github-action:1.6.0 #37
Comments
hi @kaychess! Back when I created this action this was the fastest option available (i.e. pull the action's image from docker hub). At that time I tried to use an Also, it seems that now that Github Actions is more evolved there are options that'll probably be better than the current one. I'll also have a look at that. Will get back to you once I have some improvements done 🚀 |
The action's image is now based on alpine, which reduced drastically it's size. The previous compressed size was ~352 MB, now it's only ~56 MB. Resolves #37
Hey @kaychess, I've just published version 1.7.0 which uses the alpine based image. The image's compressed size was reduced from ~352 MB to ~56 MB, which made the pull time get reduced to around ~12s as you can see In this workflow run 🎉 🚀 I also tried to use GitHub's package registry instead of docker hub for further improvement to the pull time. Turns out their registry can't be used to host actions' source code yet because they don't allow pulling images (even public ones) without authenticating. Once they add support for that I'll add this update too 💪 |
Oh Thank you very much for the update :) name: Lint
on:
push:
branches:
- master
jobs:
git_commit_messages_lint:
name: Git_commit_messages_lint
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: 12
- name: Get Last committed message and check against commit lint
run: git log -1 --pretty=%B | npx commitlint
- name: Check if there is any error
if: failure()
run: |
echo " : Error ::: Lint : Git Commit Messages "
exit 1
.... Other steps ... |
Yep, definitely! Actions and workflows can be built without docker as well. The reason why this action was made with docker was so it could already include the dependencies without configuring the node environment. You'll definitely get some seconds in the speed by running a similar code without docker 😃 |
Hello there,
I am new to git actions. Please correct me if I am stating anything wrong.
In Git actions -> jobs, I noticed that Pull wagoid/commitlint-github-action:1.6.0 step is taking
31 sec.
Is there any way to reduce this time.
Please have a look on this issue.
Thank you
The text was updated successfully, but these errors were encountered: