Extension to PR 993 #995
Merged
Extension to PR 993 #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…991_v3_tempcolumn_adhoccsv_calibration
…991_v3_tempcolumn_adhoccsv_calibration
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #995 +/- ##
==========================================
+ Coverage 78.43% 78.45% +0.01%
==========================================
Files 99 99
Lines 13391 13384 -7
==========================================
- Hits 10503 10500 -3
+ Misses 2888 2884 -4 ☔ View full report in Codecov by Sentry. |
|
sorry, commit 61bb99b was not intended for this branch, but will leave it now as it will not do any harm. |
|
UPDATE: I am now investigating the codecov issue in a separate branch as I realise it is not practical to have that in this branch. |
(depending on whether the timestamp column is there)
edit to PR 995, corercting temperature column location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends code updates in PR #993 to g.getmeta because also that function did not effectively use the temperature data from the ad-hoc csv format.
I have tested this with:
rmc.col.temp = c(),in order to simulate not having temperatureAdditionally, I am updating the code coverage workflow file (.yml) to align with the latest template offered by https://github.com/r-lib/actions/blob/v2-branch/examples/test-coverage.yaml I do this because recently code coverage gives all kinds of redundant warnings about the test coverage dropping in certain commits. I think this is overkill for a package like GGIR. Coverage is nice to know and we will try to keep coverage high, but having these warnings with every commit is too much to worry about I think. Hopefully the new template removes this behaviour. => update: i found out that adding a codecov.yml file to root of the repo allows for configuring this behaviour.Checklist before merging:
inst/NEWS.Rdwith a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTIONfile, if you think you made a significant contribution.