Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #988

Merged
merged 11 commits into from
Dec 13, 2023
Merged

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Dec 5, 2023

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ededec3) 78.41% compared to head (b6df3fd) 78.46%.

❗ Current head b6df3fd differs from pull request most recent head a464699. Consider uploading reports for the commit a464699 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #988      +/-   ##
==========================================
+ Coverage   78.41%   78.46%   +0.04%     
==========================================
  Files          99       99              
  Lines       13371    13367       -4     
==========================================
+ Hits        10485    10488       +3     
+ Misses       2886     2879       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentvanhees vincentvanhees marked this pull request as ready for review December 6, 2023 07:05
Copy link
Collaborator

@jhmigueles jhmigueles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation reads well, I don't have further comments here. Thanks!

@vincentvanhees vincentvanhees merged commit e57719b into master Dec 13, 2023
7 checks passed
@vincentvanhees vincentvanhees deleted the issue980_guidance_segmentDAYSPTcrit branch December 13, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants