Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make backward compatible with R 4.2.0 #1255

Merged
merged 5 commits into from
Jan 22, 2025
Merged

Make backward compatible with R 4.2.0 #1255

merged 5 commits into from
Jan 22, 2025

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Jan 22, 2025 •
edited
Loading

I have test this by installing R 4.2.0 and running all tests on it.
Further, i have ran one of my GGIR scripts to process some real study data.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Clean code has been attempted, e.g. intuitive object names and no code redundancy.
  • Documentation updated:
    • Function documentation
    • Chapter vignettes for GitHub IO
    • Vignettes for CRAN
  • Corresponding issue tagged in PR message. If no issue exist, please create an issue and tag it.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.
  • GGIR parameters were added/removed. If yes, please also complete checklist below.

@vincentvanhees vincentvanhees changed the title Make GGIR backward compatible with R 4.2.0 Make backward compatible with R 4.2.0 Jan 22, 2025
@vincentvanhees vincentvanhees marked this pull request as ready for review January 22, 2025 17:13
@vincentvanhees vincentvanhees merged commit 739facd into master Jan 22, 2025
7 checks passed
@vincentvanhees vincentvanhees deleted the test_with_R42 branch January 23, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'Origin' must be supplied Error in as.POSIXlt.numeric(x) : 'origin' must be supplied (for older R versions)
1 participant
@vincentvanhees