-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise and expand circadian rhythm and fragmentation analyses based on recent publications #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Victor Barreto Mesquita <54644227+victormesquita40@users.noreply.github.com> Co-Authored-By: Ian Danilevicz <43249776+iandanilevicz@users.noreply.github.com>
…on, update documentation #955
Revise IV and IS calculation + integrate in both part2 and part6
…S and putting scaling inside function
Add fragmentation metrics to PR1028
... merged because has extensively been tested by project partners and because this will for now only be a GitHub release in a couple of months it will be part of a CRAN release, so enough time to spot missed issues, if any. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises and expands a variety of circadian rhythm and fragmentation measures as described by Danilevicz et al. 2024.
Note that this was all part of a previous PR draft that I closed PR #1028, see that PR for a more detailed description of the updates. The only new thing in the current PR is that I have updated the documentation.
Closes #955.
My plan is to merge this PR after the 3.1-5 release which is scheduled for next week on the 7th of November. In the meantime I may be making (minor) additional commits to this PR to improve the documentation or code clarity.
Checklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
file, if you think you made a significant contribution.If NEW GGIR parameter(s) were added then these NEW parameter(s) are:
man/GGIR.Rd
R/load_params.R
R/check_params.R
vignettes/GGIRParameters.Rmd
with references to the GGIR parts the parameter is used in.If GGIR parameter(s) were deprecated these parameter(s) are:
man/GGIR.Rd
R/load_params.R
R/check_params.R
vignettes/GGIRParameters.Rmd
R/extract_params.R
with deprecated parameters such that these do not produce warnings when found in old config.csv files.