Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small changes #1209

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Small changes #1209

merged 3 commits into from
Oct 4, 2024

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Oct 4, 2024

  1. Fixes Missing declaration of loaded object in g.part5 causes NOTE in package check #1208 by adding declaration of object.
  2. Reverses threshold changes in 3.1-3 relating to Non-wear detection in the middle of the SPT window #1172
  3. Update read.myacc.csv documentation:

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Clean code has been attempted, e.g. intuitive object names and no code redundancy.
  • Documentation updated:
    • Function documentation
    • Chapter vignettes for GitHub IO
    • Vignettes for CRAN
  • Corresponding issue tagged in PR message. If no issue exist, please create an issue and tag it.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.
  • GGIR parameters were added/removed. If yes, please also complete checklist below.

remove rmc.desiredtz and rmc.configtz from examples in the vignette as these are scheduled for deprecation, further emphasize that user should always first test their arguments with read.myacc.csv directly.
@vincentvanhees vincentvanhees marked this pull request as ready for review October 4, 2024 14:04
@vincentvanhees vincentvanhees merged commit 0e98108 into master Oct 4, 2024
7 checks passed
@vincentvanhees vincentvanhees deleted the issue1208_NOTE branch October 7, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing declaration of loaded object in g.part5 causes NOTE in package check
1 participant