Fix issue with non-default dayborder in part 5 #1008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1006
The problem was that
g.part5.definedays.R()
did not correctly expand objectnightsi
. @jhmigueles this relates to theqwindow
implementation in part 5 you did, so it would be good if you could check that this does not break any functionality you intended.Further, in this PR includes minor fixes:
cat()
statements that are not informative for the user, also I opened a new issue Make code less verbose and review need for cat() statements #1007 to do a more systematic review of this in the new yearChecklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
file, if you think you made a significant contribution.