avoid zzz to crash when offline, fixes #1203

wadpac · Sep 24, 2024 · 4cdb02b · 4cdb02b
1 parent bae9171
commit 4cdb02b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -2,6 +2,8 @@
 
 - Part 5: Add parameters require_complete_lastnight_part5 to control whether last window is included if last night is incomplete. #1196
 
+- General: GGIR version look-up in .onattach() now skipped when computer is offline, fixes #1203.
+
 # CHANGES IN GGIR VERSION 3.1-4
 
 - Part 3: Update threshold used for HorAngle to 60 degree, and auto-setting HASPT.ignore.invalid to NA when NotWorn guider is used. #1186

diff --git a/R/zzz.R b/R/zzz.R
@@ -15,6 +15,7 @@
   cran_version <- package_version(pkgs[which(pkgs[,1] == "GGIR"),"Version"])
   local_version <- packageVersion("GGIR")
   behind_cran <- cran_version > local_version
+  if (length(behind_cran) == 0) return() # handle no internet connection
   if (interactive()) {
     if (behind_cran) {
       msg <- paste0("A newer version of GGIR is available with bug fixes and new features. [", local_version," --> ", cran_version, "]")