Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure target dir for replay exists #36

Merged
merged 1 commit into from
Dec 4, 2023
Merged

fix: ensure target dir for replay exists #36

merged 1 commit into from
Dec 4, 2023

Conversation

kfot
Copy link
Contributor

@kfot kfot commented Dec 1, 2023

No description provided.

@fluxxu
Copy link
Collaborator

fluxxu commented Dec 1, 2023 •
edited
Loading

Hi! Thank you for the PR!

I suggest moving the folder creation code to:

https://github.com/w3champions/flo/blob/develop/crates/client/src/lan/game/game.rs#L198

The open call should fail if the parent folder doesn't exist. This behavior aligns with that of std::fs::File::create.
image

@kfot kfot force-pushed the fix/missing_replay_dir branch 2 times, most recently from 486b6b0 to 6756d70 Compare December 1, 2023 21:44
@kfot kfot force-pushed the fix/missing_replay_dir branch from 6756d70 to 28cc0c2 Compare December 2, 2023 15:57
@fluxxu fluxxu merged commit 485e06a into w3champions:develop Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluxxu fluxxu fluxxu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kfot @fluxxu