Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add integrity property #425

Merged
merged 5 commits into from
Apr 16, 2019
Merged

add integrity property #425

merged 5 commits into from
Apr 16, 2019

Conversation

mattgarrish
Copy link
Member

This PR addresses the issue raised in #398 by adding an integrity property to the LinkedResource object definition and making the value conforming to the Subresource Identification specification.

@iherman
Copy link
Member

iherman commented Apr 16, 2019

Copy link
Member

@iherman iherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The WebIDL must get a new entry with DOMString.
  2. It may be worth making it clear in the value type that it is a space separated list of values (in contrast to other terms). Editorially, I would put this remark after the table, otherwise the table cell becomes unreadable...
  3. We should try to generate a proper hash value to be added to an example...

@iherman
Copy link
Member

iherman commented Apr 16, 2019

"defintion [sri]." -> "definition [sri]" :-)

@iherman
Copy link
Member

iherman commented Apr 16, 2019

For me, it is a go... :-)

@mattgarrish mattgarrish merged commit 4e9fe40 into master Apr 16, 2019
@mattgarrish mattgarrish deleted the feature/integrity branch April 16, 2019 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants