-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "User agents that do not support CSS" conformance class. #389
Add a "User agents that do not support CSS" conformance class. #389
Conversation
Addresses issue w3c#361 Adds the new conformance class and clarifies a couple of places where "user agent" was used such that there may have been confusion as to a possibility for reference to different types of user agents.
ping @TairT for review |
From my side a merge of this PR needs to wait for a solution of #365. See also #395 (comment) and #361 (comment). |
@dwsinger I need a reviewer on this patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in english requires takes a gerund, so "requires to apply" should probably be "requires applying" except I am hesitant to alter definition text...
I'm going to replace /requires to/ with /says to/. I'm proposing to introduce 3 conformance classes as per #410 - patch upcoming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented in #361 all UA conformance classes need to support color. Either this is not the case through the latest changes (see comments) or this not made clear enough.
index.bs
Outdated
<dd><p>All processing requirements in this specification apply, except those in | ||
[[#css-extensions]]. The user agent must instead implement equivalent visual rendering to what a | ||
CSS based renderer produces according to [[#rendering]]. [[#applying-css-properties]] lists the | ||
default styling properties in CSS speak that will also define the default styling in such user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may mistankingly imply that all CSS extension features need to be supported. But this is not what is intended?
index.bs
Outdated
relate to stylesheets and CSS, and all of [[#rendering]] and [[#css-extensions]]. The user agent | ||
must instead only render the text inside <a>WebVTT cue text</a> in an appropriate manner. Any other | ||
styling and positioning instructions are optional.</p> </dd> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I misunderstood something, we seem to go in circles.
When it says for "User agents that do not support CSS"
The user agent must instead only render the text inside WebVTT cue text in an appropriate manner. Any other styling and positioning instructions are optional.
...it seems again also exlcude the required support for color. It even goes further and makes positioning (which is not defined by CSS extensions but by Cue settings) optional.
Obviously not clear enough. Non-CSS UAs are not required to parse and implement STYLE blocks, i.e. new CSS. They must nonetheless respect markup in cues, and the layout model (both of which are CSS-derived). |
Ah ok, misunderstanding from my side. I thought that no CSS means none of the CSS functionality. |
I think supporting pre-defined colors is unproblematic, and what we agreed with Andreas... |
It's ok, I only just connected the dots how that referred back to the colors. I'll propose a change next week. |
@silviapfeiffer Thanks! |
Also remove optional positioning for non-CSS UAs.
I've explicitly stated now that the color classes must be supported by every conformance class, with or without CSS. @TairT could you re-review? Thanks! |
Thanks
I believe that this means that a non-CSS UA is not able to or required to parse STYLE blocks or otherwise allow for the definition of new styles, but is required to follow the built-in layout and styling rules (which can be implemented by, and match the semantics of, CSS).
thanks
On Jan 5, 2018, at 6:40 , Silvia Pfeiffer ***@***.***> wrote:
I've explicitly stated now that the color classes must be supported by every conformance class, with or without CSS. @TairT could you re-review? Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
David Singer
Manager, Software Standards, Apple Inc.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @silviapfeiffer! It was a long way but finally we got there. Thanks to @silviapfeiffer and @dwsinger for your patience.
Awesome, thanks! |
thank you both for your patience and persistence also |
This actually introduces a definition for "WebVTT cue setting" and
clarifies how they provide information to position and align the cue
box and cue text.
Closes #361