Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for parsing async iterable<T> type #775

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: add support for parsing async iterable<T> type #775

wants to merge 2 commits into from

Conversation

lucacasonato
Copy link
Contributor

Adds support for async iterable<T> (whatwg/webidl#1397).

This was referenced Mar 26, 2024
Draft
Open
@lucacasonato lucacasonato marked this pull request as ready for review January 24, 2025 13:12
@lucacasonato
Copy link
Contributor Author

This is now ready for review.

saschanaz
saschanaz requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, but I do not see the change corresponding to constants:

Async iterables must not be used as the type of an attribute or constant.

The Constant interface currently has no validate() but it'll be called automatically by Container when you add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschanaz saschanaz saschanaz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacasonato @saschanaz