Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Minutes 2021-08-19 Meeting #65

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Publish Minutes 2021-08-19 Meeting #65

merged 6 commits into from
Aug 26, 2021

Conversation

mukul-p
Copy link
Collaborator

@mukul-p mukul-p commented Aug 20, 2021

Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit

Using a process similar to #23.

During this meeting, we discussed #60, #1, #30. We also discussed administrivia - logistics of meeting at this time-slot (6am UTC); how to add to agenda to future meetings; and one participant created agenda-item - Is discussion on service-workers in scope of the meeting.

@mukul-p mukul-p requested review from Rob--W and dotproto August 20, 2021 10:04
@mukul-p mukul-p changed the title Minutes 19 sept2021 Publish Minutes 19 Sept 2021 Meeting Aug 20, 2021
@mukul-p mukul-p changed the title Publish Minutes 19 Sept 2021 Meeting Publish Minutes 2021-08-19 Meeting Aug 20, 2021
Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also edit https://github.com/w3c/webextensions/blob/main/_minutes/README.md and link the new notes in "Past meetings"?

Usually I would also add another meeting to "Upcoming meetings", but this time wouldn't do that until we have had some discussions about potentially adjusting the schedule (#63).

_minutes/2021-08-19-wecg.md Outdated Show resolved Hide resolved
@mukul-p mukul-p requested a review from Rob--W August 23, 2021 13:57
@@ -1,4 +1,4 @@
# WECG Meetings 2021, Public NotesAug 19, 2021
# WECG Meetings 2021, Public Notes, Aug 19, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without , 2021 at the end.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version of the notes still contain , 2021 at the end.

Could you change it to the following:

# WECG Meetings 2021, Public Notes, Aug 19

_minutes/README.md Outdated Show resolved Hide resolved
@mukul-p mukul-p requested a review from Rob--W August 26, 2021 15:41
Rob--W
Rob--W previously requested changes Aug 26, 2021
@@ -1,4 +1,4 @@
# WECG Meetings 2021, Public NotesAug 19, 2021
# WECG Meetings 2021, Public Notes, Aug 19, 2021
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current version of the notes still contain , 2021 at the end.

Could you change it to the following:

# WECG Meetings 2021, Public Notes, Aug 19

@dotproto
Copy link
Member

Could you also edit https://github.com/w3c/webextensions/blob/main/_minutes/README.md and link the new notes in "Past meetings"?

Usually I would also add another meeting to "Upcoming meetings", but this time wouldn't do that until we have had some discussions about potentially adjusting the schedule (#63).

In the interest of merging this PR I think it would be best to tackle this in a follow up and merge what we have now.

@dotproto dotproto dismissed Rob--W’s stale review August 26, 2021 17:13

I suggested this change and applied it to the PR in 0e6698f

@dotproto dotproto merged commit d24ba40 into main Aug 26, 2021
@dotproto dotproto deleted the minutes-19Sept2021 branch August 26, 2021 17:14
@dotproto
Copy link
Member

In the interest of merging this PR I think it would be best to tackle this in a follow up and merge what we have now.

Oops, I missed that @mukul-p already integrated this feedback. Nice job :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants