Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add orientation metadata to VideoDecoderConfig, update algorithms #874

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Add orientation metadata to VideoDecoderConfig, update algorithms #874

merged 2 commits into from
Jan 29, 2025

Conversation

dalecurtis
Copy link
Contributor

@dalecurtis dalecurtis commented Jan 27, 2025 •
edited by pr-preview bot
Loading

As proposed on the issue and discussed in WG, this does the following:

  • Adds rotation/flip fields to VideoDecoderConfig.
  • Updates the "Create a VideoFrame" algorithm used by the video and image decoders to accept these fields.
  • Updates the video and image decoding algorithms to provide these fields during decoding.

Bug: #351

Preview | Diff

@dalecurtis dalecurtis requested review from Djuffin and padenot January 27, 2025 23:59
@dalecurtis
Copy link
Contributor Author

Hmm, I can't seem to rebase this to pass the checks, but there are no failures in this change after my other fixes AFAICT.

@Djuffin
Copy link
Contributor

Djuffin commented Jan 28, 2025 •
edited
Loading

This PR is still 2 commits behind main
see here

try rebasing decode_spec branch

@dalecurtis
Add orientation metadata to VideoDecoderConfig, update algorithms
80f011b 
As proposed on the issue and discussed in WG, this does the following:
- Adds rotation/flip fields to VideoDecoderConfig.
- Updates the "Create a VideoFrame" algorithm used by the video
and image decoders to accept these fields.
- Updates the video and image decoding algorithms to provide
these fields during decoding.

Bug: #351
@dalecurtis
Copy link
Contributor Author

CLI rebase required me to use --force to push, but per chat that seems to be the way to go. Should be ready to go now.

Djuffin
Djuffin reviewed Jan 28, 2025
View reviewed changes
@dalecurtis dalecurtis requested a review from Djuffin January 29, 2025 00:48
@dalecurtis dalecurtis merged commit 90090dc into main Jan 29, 2025
2 checks passed
@dalecurtis dalecurtis deleted the decode_spec branch January 29, 2025 17:28
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 10, 2025
@dalecurtis @chromium-wpt-export-bot
Implement orientation support for WebCodecs VideoDecoder.
19753b0 
This implements the current spec language by copying the provided
transform from the VideoDecoderConfig to each output frame. See
w3c/webcodecs#874 for spec details.

As part of this, the codec specific wpt test code is split into
its own file to make adding new tests (to avoid breaking interop
agreements).

R=eugene

Bug: 327625558
Change-Id: I7c96007a27a634c8da80b72266171c8e13645e46
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Feb 10, 2025
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Feb 11, 2025
@dalecurtis
Implement orientation support for WebCodecs VideoDecoder.
9c860e1 
This implements the current spec language by copying the provided
transform from the VideoDecoderConfig to each output frame. See
w3c/webcodecs#874 for spec details.

As part of this, the codec specific wpt test code is split into
its own file to make adding new tests (to avoid breaking interop
agreements).

R=eugene

Bug: 327625558
Change-Id: I7c96007a27a634c8da80b72266171c8e13645e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221543
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418353}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 11, 2025
@dalecurtis @chromium-wpt-export-bot
Implement orientation support for WebCodecs VideoDecoder.
dc63a4d 
This implements the current spec language by copying the provided
transform from the VideoDecoderConfig to each output frame. See
w3c/webcodecs#874 for spec details.

As part of this, the codec specific wpt test code is split into
its own file to make adding new tests (to avoid breaking interop
agreements).

R=eugene

Bug: 327625558
Change-Id: I7c96007a27a634c8da80b72266171c8e13645e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221543
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418353}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Feb 11, 2025
@dalecurtis @chromium-wpt-export-bot
Implement orientation support for WebCodecs VideoDecoder.
e905cf1 
This implements the current spec language by copying the provided
transform from the VideoDecoderConfig to each output frame. See
w3c/webcodecs#874 for spec details.

As part of this, the codec specific wpt test code is split into
its own file to make adding new tests (to avoid breaking interop
agreements).

R=eugene

Bug: 327625558
Change-Id: I7c96007a27a634c8da80b72266171c8e13645e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221543
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418353}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 13, 2025
@dalecurtis @moz-wptsync-bot
Bug 1947322 [wpt PR 50618] - Implement orientation support for WebCod…
ab12fe7 
…ecs VideoDecoder., a=testonly

Automatic update from web-platform-tests
Implement orientation support for WebCodecs VideoDecoder.

This implements the current spec language by copying the provided
transform from the VideoDecoderConfig to each output frame. See
w3c/webcodecs#874 for spec details.

As part of this, the codec specific wpt test code is split into
its own file to make adding new tests (to avoid breaking interop
agreements).

R=eugene

Bug: 327625558
Change-Id: I7c96007a27a634c8da80b72266171c8e13645e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221543
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418353}

--

wpt-commits: e905cf1339f0f65cbd8c063f4699aaeae4126587
wpt-pr: 50618
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Feb 15, 2025
@dalecurtis @moz-wptsync-bot
Bug 1947322 [wpt PR 50618] - Implement orientation support for WebCod…
3bd4f36 
…ecs VideoDecoder., a=testonly

Automatic update from web-platform-tests
Implement orientation support for WebCodecs VideoDecoder.

This implements the current spec language by copying the provided
transform from the VideoDecoderConfig to each output frame. See
w3c/webcodecs#874 for spec details.

As part of this, the codec specific wpt test code is split into
its own file to make adding new tests (to avoid breaking interop
agreements).

R=eugene

Bug: 327625558
Change-Id: I7c96007a27a634c8da80b72266171c8e13645e46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221543
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Eugene Zemtsov <eugene@chromium.org>
Reviewed-by: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1418353}

--

wpt-commits: e905cf1339f0f65cbd8c063f4699aaeae4126587
wpt-pr: 50618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djuffin Djuffin Djuffin approved these changes

@padenot padenot padenot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dalecurtis @Djuffin @padenot