Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F26 update to address 258 #776

Merged
merged 1 commit into from
Jul 11, 2019
Merged

F26 update to address 258 #776

merged 1 commit into from
Jul 11, 2019

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Jun 10, 2019 •
edited
Loading

Closes #258

@alastc alastc mentioned this pull request Jun 10, 2019
Closed
@patrickhlauke
Copy link
Member

@alastc note that #767 actually deletes F26 (i had forgotten about that other issue #258)

@alastc
Copy link
Contributor Author

alastc commented Jun 10, 2019

Gah, that's what happens when you start from the bottom. Ok, this is a fallback if that one doesn't go through then.

@alastc alastc merged commit 8013bd1 into master Jul 11, 2019
@alastc alastc deleted the F26-update-258 branch July 11, 2019 15:59
@alastc
Copy link
Contributor Author

alastc commented Jul 11, 2019

So, somewhat confusingly this update was approved (to close #258), so I'll merge it in.

It may well be that the whole technique is removed later, but in the meantime there is one less PR & issue to deal with :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure F26 links to the wrong SC?
2 participants
@alastc @patrickhlauke