Pointer cancellation jake suggestions #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incorporated feedback from Jake
Made the "New" be capitalized to match dominant style
"new" now "New"
This was referenced Apr 29, 2019
|
+1 looks fine to me |
|
-1 Hi @mbgower shouldn't we need to remove the word new altogether? |
|
see also: #708 (comment) |
|
Hi @jake-abma, The 'new' is from the build-generator, that's in Michael's (very long) to-do list, and shouldn't affect the other aspects. |
|
In fact, the technique updates were mostly already done in master, so I'm going to merge this one, it's purely editorial and will be over-ridden by whatever MichaelC does with the generator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressed editorial raised by Jake
Closes #707