Migrate Reflow videos to WAI Understanding WCAG YouTube account #4304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
af49d70 to
d7808c8
Compare
|
I hope you're not planning to use the YouTube embedded media player. The accessibility is very poor and there's nothing you can do about it. Able Player is a much better choice and it can play videos hosted on YouTube, although a few of the accessibility issues remain. The best solution is Able Player with the videos hosted somewhere else. |
|
@TestPartners thanks for the additional feedback. Fortunately, after more conversations with the team, we should have a more direct option available that won't require reliance on YouTube embeds. I'm going to close this. |
mbgower
added a commit
that referenced
this pull request
Apr 1, 2025
Resolves #768 Alternative to #4304 that instead migrates videos to W3C's Cloudflare Stream account. The videos have been marked as downloadable, so they can be embedded identically to how they were before. In addition to removing the mp4s from the repo, I've cleaned up a commented-out gif, and made sure each video has alternative text. (Note that although the videos are removed, they are still in git history and thus still consume space; the intent is for this to be the pattern going forward and to avoid adding more mp4 files to the repository.) [Preview](https://deploy-preview-4308--wcag2.netlify.app/understanding/reflow) Co-authored-by: Mike Gower <mikegower@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal; I'm opening this PR to generate a preview to allow for further evaluation/discussion.
This replaces the mp4 files that were merged in #4055 with YouTube video embeds, using unlisted videos posted to a WAI account. It is coded using a pattern that avoids loading until direct interaction. The pattern is centralized in an include file, intended to make instances as easy as possible to adapt from YouTube's iframe embed code snippets.
The goal of this is to establish a pattern to avoid adding binary files of significant size to the repository, which would ultimately have the effect of irreversibly growing the repository size, impacting everyone who needs to work with it locally.
I tried this approach first, since it is feasible for the WAI team to manage without additional dependencies. This particular approach does have downsides:
&mute=1in webkit browsers, even withallow="autoplay"included; this is fine for these videos which have no audio, but worth noting for future. (This PR avoids loading the embeds on page load, so autoplay is only taking effect after an initial user interaction; without it, playing would require 2 clicks)@netlify /understanding/reflow