Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 publication fixes #4173

Merged
merged 4 commits into from
Dec 12, 2024
Merged

2024 publication fixes #4173

merged 4 commits into from
Dec 12, 2024

Conversation

iadawn
Copy link
Contributor

@iadawn iadawn commented Dec 12, 2024

No description provided.

@iadawn iadawn changed the base branch from main to WCAG-2.1 December 12, 2024 12:20
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for wcag2 failed.

Name Link
🔨 Latest commit 6348008
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/675ad4e88e81850008ab84ac

@iadawn iadawn requested a review from kfranqueiro December 12, 2024 12:21
@iadawn
Copy link
Contributor Author

iadawn commented Dec 12, 2024

@kfranqueiro, not sure if there is anything in the deploy fails that I need to worry about

@kfranqueiro
Copy link
Contributor

The failure is because the WCAG-2.1 branch doesn't have the whole eleventy build system and package.json, and netlify is attempting to build against that for this PR. So that's a red herring.

@kfranqueiro
Copy link
Contributor

I presume this is intentionally a subset of what was added to the change log on main for 2.2.

Tangentially, a couple of notes about the change log on main (as presently seen at https://w3c.github.io/wcag/guidelines/22/#changelog):

  • 2.2's change log for the new publication uses a nested list rather than a separate paragraph + top-level list
  • The top-level list item introducing the new publication's changes in 2.2's change log says "2024-12-1w" (a placeholder?)

@iadawn iadawn merged commit 2dd3043 into WCAG-2.1 Dec 12, 2024
1 of 5 checks passed
@kfranqueiro kfranqueiro deleted the 2024-publication-fixes branch December 13, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants