Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add F42 as failure for 4.1.2 #4052

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Add F42 as failure for 4.1.2 #4052

merged 2 commits into from
Oct 9, 2024

Conversation

patrickhlauke
Copy link
Member

@patrickhlauke patrickhlauke commented Sep 3, 2024

Closes #1263

(also cleans up the markup of 4.1.2 understanding, removing all unnecessary/excessive line breaks, fixes the invalid use of </meta>, and removes the unnecessary techniques link text which is autopopulated at publish time)

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for wcag2 ready!

Name Link
🔨 Latest commit 633684e
🔍 Latest deploy log https://app.netlify.com/sites/wcag2/deploys/66d6df628ec45f00089b77a3
😎 Deploy Preview https://deploy-preview-4052--wcag2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

these are auto-populated by the publishing script
@patrickhlauke
Copy link
Member Author

patrickhlauke commented Sep 3, 2024

@detlevhfischer
Copy link
Contributor

At to F42, section "Example 4: Scripting a div element": the code example at the end has no tabindex="0" but the example intro claims the author has made the pseudo-link keyboard-accessible.
Should this technique have a note that if pseudo-links that are fully keyboard accessible and carry a role="link", they would not fail?

I can create a PR to implement that if people think it would be worthwhile doing.

@patrickhlauke
Copy link
Member Author

At to F42, section "Example 4: Scripting a div element": the code example at the end has no tabindex="0" but the example intro claims the author has made the pseudo-link keyboard-accessible.

urgh, good catch. suggest making a small PR for that fix

Should this technique have a note that if pseudo-links that are fully keyboard accessible and carry a role="link", they would not fail?

the technique already has the note about "It is possible to use the ARIA role attribute to identify an anonymous element as link control for assistive technologies …". the "fully keyboard accessible" part would be relevant for the 2.1.1 aspect, yes. Suggest amending/expanding that note to clarify that part yes (can be in the same PR as the above)

Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I diffed builds before/after the changes in this PR to confirm that nothing unexpected happened due to the formatting cleanup.

@alastc alastc merged commit 602926f into main Oct 9, 2024
5 checks passed
@alastc alastc deleted the patrickhlauke-issue1263 branch October 9, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title of F42 indicates it applies to SC 4.1.2 - but 4.1.2 is not listed in the technique
5 participants