Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio control #2621

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Audio control #2621

merged 5 commits into from
Jun 6, 2023

Conversation

alastc
Copy link
Contributor

@alastc alastc commented Aug 16, 2022

Michael Gower's suggestion for #1533

@@ -4,8 +4,8 @@ <h4>Audio Control</h4>

<p class="conformance-level">A</p>

<p>If any audio on a Web page plays automatically for more than 3 seconds, either a <a>mechanism</a> is available to pause or stop the audio, or a mechanism is available to control audio
volume independently from the overall system volume level.
<p>If any audio on a Web page plays automatically for more than 3 seconds, either a <a>mechanism</a> is available to pause or stop the audio or a mechanism is available to control audio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, think it reads a bit awkard and long without that comma after "stop the audio", but i agree with that added comma in the next line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, it has a lot of "or"s, but I think that's the way to make clear it applies to both.

@patrickhlauke
Copy link
Member

any chance the second note from https://github.com/w3c/wcag/pull/1825/files could also be grafted onto this? then i'd be happy to close #1825 in preference to this PR

@alastc
Copy link
Contributor Author

alastc commented Aug 16, 2022

On the paragraph, we had a comment that I agree with: "As not all user agents have this capability, the author may not rely on it. So this paragraph does not help the author, as they need to care themselves anyway."
(I think "care themselves" means they have to take care of it anyway.)

@patrickhlauke
Copy link
Member

On the paragraph, we had a comment that I agree with: "As not all user agents have this capability, the author may not rely on it. So this paragraph does not help the author, as they need to care themselves anyway." (I think "care themselves" means they have to take care of it anyway.)

They can rely on it if they're only supporting a platform/user agent that does have it (though not applicable to open web, more closed systems).

But I do think it's worth having something that explains that this can't be relied on/does not pass. It helps auditors in determining whether it's a pass or fail...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants