Add note to 2.1.4 Character Key Shortcuts understanding #2455
Conversation
Make the point that while the SC itself refers to "character keys", it's nothing to do with how many keys are pressed. Also correct a typo, and gives the document a proper `<title>` (though irrelevant, as this is changed on publication, it's still nice for good housekeeping). Closes #2314
…uts/keys mentioned in the document
ba89b40 to
b4d5531
Compare
|
@alastc any chance this could be discussed/considered at some point soon? |
correct indentation of the html
There was a problem hiding this comment.
Should the revised understanding have something on videos processing single printable key shortcuts once they receive focus? The question has been popping up (can't remember where) whether the whole of the video as it receives focus can count as "user interface component" to allow it to be "active only on focus". I can see a good case for allowing that, and I'am not aware of drawbacks. Not sure whether this question should be lumped together with this clarifying rewrite though...
|
@detlevhfischer i'd keep that thing about video players separate, as a resolution to #1950 (if we ever manage to get some consensus, and then if we ever manage to actually make a PR and merge something in a timely fashion ;) ) |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Alastair Campbell <ac@alastc.com>
When #3939 was merged, conflicts were not resolved correctly, resulting in loss of #2455's update to 2.1.4 and loss of #3939's original update to 2.3.3. This PR cleanly re-applies my original changes from #3939, restoring those other lost updates. --------- Co-authored-by: Patrick H. Lauke <redux@splintered.co.uk>
|
@detlevhfischer sorry, a super-late rejoined to this: in a11y slack https://web-a11y.slack.com/archives/C7KTV5CBA/p1736926950552289 somebody pointed out that http://3needs.org/en/testing/code/kb-shortcuts.html seems to omit/not test all printable characters, such as |
|
@patrickhlauke Thanks, I'll pass this on to Telekom MMS, this is not our Bookmarklet I just used it to show its operation on a test page. This thing is that on a German (and presumably also English) keyboard, producing é actually involves hitting two keys so I am not sure if these special characters would really need to be covered - where do you stop? Other languages have other diacritical characters... |
well that's the point of this PR here. it's not about "how many physical keys do you need to press", but rather "is it a printable character". and yes, in theory, you need to test the entire unicode ranges of printable characters... (note, for instance, the ACT test, that goes into all the unicode ranges that are covered). but at least, making the bookmarklet a bit more expansive to cover punctuation and diacritics for western use... |
Make the point that while the SC itself refers to "character keys", it's nothing to do with how many keys are pressed.
Also corrects a typo, gives the document a proper
<title>(though irrelevant, as this is changed on publication, it's still nice for good housekeeping), and uses<kbd>for the characters mentioned.Closes #2314