-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 291 #2435
Conversation
Addresses Issue 291. Creates a new HTML technique document for using HTML landmarks to identify regions of a page.
1. removes outdated content (HTML 4.01, XHTML 1.0). 2. updates links to out-of-date URLs, adds https, etc. 3. updates code examples to match HTML100 4. Adds two new Tests and Expected Results
Thanks for this work, @fstrr. It's a significant improvement. I think it would be an idea to call the HTML equivalent by the name given in the spec ("semantic elements") , or some modification of it like structural semantic elements. I also think it needs to be clearer to distinguish between the two and make it clear that when html exist, the landmarks do not need to be added. They are redundant (and I think the screen readers have matured enough now that we don't need to request they be added?). On another topic...
This next comment is likely to evolve into a large discussion, but I will note that we have explored whether it is always entirely necessary to label multiple occurrences of the same landmark. For instance, how much weight should we give to hierarchy?
As stated, that is probably best dealt with as a separate issue. i will undertake to create that. |
hey, @mbgower Thanks for the feedback. Would "Using semantic HTML elements to identify regions of a page" be a better document title? The "For instance, if a navigation role is used multiple times on a page, each instance may have a unique label specified using From memory, Internet Explorer needs roles added to semantic HTML for the landmarks to appear (for example: |
Yes, I think so @fstrr ! Agree with your other comments to. |
- changed title per @mbgower’s feedback. - added more HTML-specific content including not neededing to double up on ARIA roles, and more relevant resources - removed test procedure 4 - improved code examples
documents updated per your feedback (and some other things) |
@fstrr I have a concern that although you've changed the name of the HMTL5 document, you are using "landmark" primarily in the content. However, I'm not sure anyone would think of the HTML5 equivalents as being "landmarks". I went to change the terms in the article and ran into something of a Pandora's box, in that there does not seem to be consistency of terminology about these elements, even within the HTML5 specification.
|
Moved this PR to a draft. Will continue to work on this to clarify it. I'm trying to avoid the word "section" where possible to hopefully avoid confusion with the Also, as HTML is a living standard and version-less, I'm just referring to it as HTML instead of HTML5. (As a side note, I'd like to clear up all the outdated references to HTML and XHTML in the files at some point.) |
Does this ARIA Practices 1.1 ARIA Landmarks Example help?
|
It depends how technical we want to get. I am not the best person to nail this down, but my undersatnding is as follows... What aria landmarks do is better described as creating an explicit landmark role for the element, whereas the html5 sectioning element creates an implicit role. Maybe by that token we can say that the html sectioning elements create implicit landmark roles? @scottaohara may be able to give us the best suggested wording. Oh, sorry! I just realized you were quoting from the APG there!! If they're using that terminology, then I guess we can borrow from it. |
There's also H97, which relates to this. That document also needs a re-write to fix the horizontal scrolling of code examples, multiple typos, and an example that seems redundant (slightly surprised that page got approved). I'm working on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. A link to the new technique will need to be added to the appropriate understanding files.
1. marked up code as `code`. 2. removed some repetitious content 3. added more descriptive content to examples. 4. fixed some typos.
Approved: https://www.w3.org/2023/05/16-ag-minutes#item12 @michael-n-cooper - I updated the links in info & relationships to be relative (they were hard-coded to wcag21). I'll check when it is published, but hopefully that works... |
closes #291