-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update focus-appearance-minimum.html #2345
Update focus-appearance-minimum.html #2345
Conversation
An attempt to address the concerns expressed for the later comments in #2237. The closing paragraph has become a final exception bullet. A note has been added providing an example as well as information on selection versus focused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with this, but please note that this version takes away the page author/owner choice.
these requirements are applied to the sub-component instead.
I had expected to find are allowed
or similar.
Thanks, @bruce-usab . We can certainly swap 'are' with 'may be applied' language as a fallback, but my sense is that with the revision and the State note, we may be able to get away with something a bit emphatic. I've added Wilco and Alastair as reviewers, to get their perspective, since they have been heavily involved in discussion. |
fixed a missing word and tweaked at same time
Also, my apologies but I will be joining the call tomorrow (5/3) quite late and probably will miss the substantive live discussion on this item. I am however, content with where the group consensus lands. My concerns have been heard, and I appreciate @mbgower and everyone's considered interaction. |
Added the changes to the SC as well as the Understanding document
Note some other tweaking options include: option 1, remove the if and make it an "and"
option 2, same as option 1, but add in "may"
|
I think with the associated note (outlining 'selection') we can be emphatic about that, so it is an either/both scenario. I just wonder about the "and a sub-component" in a complex widget that might have different types of sub-component (e.g. calendar widget with days selected + focused + month buttons). How about: |
Ok, well, it was you suggesting it so if you withdraw the suggestion, we can carry on. Presumably with "these requirements may be applied to the sub-component instead" |
attempt to tweak language a bit
slight wording tweak
Added word 'note'
@bruce-usab in discussions on the Friday call, it was felt that the sub-component information is not really an exception, and fits better in its former location. Can you abide it there with the updated language? |
Attempts to address several questions in issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the ping. I think this is fine.
I agree that the concluding paragraph is not really an exception, and having it in parallel with the actual exceptions is awkward.
Thanks, Bruce. @alastc I suspect we may run into some synch issues on this. This PR includes the very small change to the normative text (removing sub-component example), but overall it covers the modifications to the note and some changes to the Understanding document. I don't seem to have a way of deleting this comment, or I would :) |
@mbgower can I merge this into the focus-appearance-tweaks branch and put that into a survey? |
* Modify adjacent color wording in sub-bullet * changed article for minimum bounding box changed from "a minimum" to "the minimum" to ensure it works with the 'disparate parts' note. * Update focus-appearance-minimum.html updated some guidance for selection * Update focus-appearance-minimum.html (#2345) * Update focus-appearance-minimum.html An attempt to address the concerns expressed for the later comments in #2237. The closing paragraph has become a final exception bullet. A note has been added providing an example as well as information on selection versus focused. * Update focus-appearance-minimum.html fixed a missing word and tweaked at same time * Update focus-appearance-minimum.html Added the changes to the SC as well as the Understanding document * Update focus-appearance-minimum.html attempt to tweak language a bit * Update focus-appearance-minimum.html slight wording tweak * change of sub-component language back to 'may be' * replaced 'may' with 'can' * Update focus-appearance-minimum.html Added word 'note' * moving the final bullet back in outside the exceptions * updates to understanding document Attempts to address several questions in issues * Adding notes to the SC file Co-authored-by: Alastair Campbell <ac@alastc.com> Co-authored-by: Mike Gower <gowerm@ca.ibm.com>
Saw the email, so I've merged this. |
An attempt to address the concerns expressed for the later comments in #2237.
The closing paragraph has become a final exception bullet. A note has been added providing an example as well as information on selection versus focused.
UPDATE: After discussion, returned final point to a paragraph again.