Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MathML version of the relative luminance definition #2173

Closed
4 tasks done
bruce-usab opened this issue Jan 7, 2022 · 3 comments · Fixed by #2641
Closed
4 tasks done

MathML version of the relative luminance definition #2173

bruce-usab opened this issue Jan 7, 2022 · 3 comments · Fixed by #2641

Comments

@bruce-usab
Copy link
Contributor

bruce-usab commented Jan 7, 2022

Recently, we have been taking a closer looking at the flash thresholds.

Relatedly, can we delete the last note under relative luminance which links to an xml file?

If not, then probably we should update the file, at least a little bit.

  • delete (html style) comment
  • change WCAG 2.0 (part of linked text, at top) to WCAG 2.2
  • change two URLs under references from hard-coded links (using 2.0 anchors) to relative
  • change one URL link 2.1 SC 1.4.3 to relative

It is all presentational MathML, but changing that to content MathML would be a pretty heavy lift. Also lots of cruft like: <mn>8</mn><mi>b</mi><mi>i</mi><mi>t</mi> which, as I understand it, should just be: <mi>8 bit</mi>

I am willing to take a stab at the pull request.

@bruce-usab
Copy link
Contributor Author

@alastc -- please let me know your initial disposition preference.

@awkawk
Copy link
Member

awkawk commented Jan 7, 2022

This would be a normative change - is the note wrong? I don't see the argument for this being an errata...

@bruce-usab
Copy link
Contributor Author

bruce-usab commented Jan 7, 2022

No, the note is not wrong per se. The .xml file is quite bad though, as it is using nothing but crude element syntax and at some deprecated attributes. My list of checkboxes is a minimal list of corrections needed, but they are all trivial. The .xml file was partially updated (one 2.1 link) for 2.1, but others were missed.

FWIW, the xml file opens okay directly, using Safari on OS X. (Wish I had tried that sooner.)

@michael-n-cooper michael-n-cooper self-assigned this Aug 25, 2022
michael-n-cooper pushed a commit that referenced this issue Aug 25, 2022
fixes #2173

Make modern HTML
update links
michael-n-cooper pushed a commit that referenced this issue Oct 10, 2022
* several updates

fixes #2173

Make modern HTML
update links

* make relative luminance page html and update link to it

* remove math style attributes

* Update the definition for recent changes, except for the MathML

* update the mathml

* remove unneeded
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants