For publication / deploy on Wednesday April 12 or Thursday April 13 (see comments for date determination) #210
Conversation
Content Magnification Fixes [resolves aria-practices issue 2606]
Support tables support
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @alflennik @mcking65 @a11ydoer @daniel-montalvo |
|
@shawna-slh I do see it in the assistive technology support section, it's the last heading on the page, here's a screenshot of what I'm seeing:
|
Support about restructure
|
@shawna-slh assuming my comment cleared things up, we are ready to release! |
|
Ah, I was looking for it in the Page Contents box -- and with my configuration, I don't see it: even when I scroll down: So that's a separate issue. I'll leave it to you all to create an Issue for that. |
|
Hi @alflennik @mcking65 I would expect these pages to get more traction given the imminent blog announcement. Even if it is not related to AT support tables, it seems to me that having an example that lacks visual focus indication is problematic and can raise some eyebrows. If I am not mistaking, the button examples are one of the four that will have the new tables, so that is yet another reason for people to look specifically at this pages. I would suggest we prioritize this. |
|
@shawna-slh thank you for sharing the screenshot, I can see that in your setup the page contents navigation box is so tall it's clipping off the bottom of the screen. The part that especially gives me pause is that the links in the box are wrapping so much, for example the "Role, Property, State and Tabindex Attributes" link is wrapped over four lines. I tried a few ways to reproduce this issue, including changing the default text size, but I couldn't get that amount of wrapping to occur. Looking at your screenshots I can see that there might be some custom css styles applied to the site. Would you mind checking if the issue still occurs without the styles present? Also would it be possible to let me know what your default text size is? |
|
Hi @daniel-montalvo, thank you for emphasizing the importance of the button focus issue, I agree that it's an eyebrow raiser. I opened a PR here: w3c/aria-practices#2673 and, pending review, the fix should be in the next release. |
|
@alflennik, with w3c/aria-practices#2673 merged, should we try to include it in this PR before the publication? |
|
@mcking65 I updated the PR with the typo fix and the button focus indicator fix, I'm glad we had a chance to fix those. |
|
@mcking65 @alflennik @a11ydoer It looks like we'll get the blog issues worked out. Shall I publish this now, while Alex is available to QA it? |
|
@shawna-slh Yes, we are on track for Monday announcement, so let's please push this to production. |
|
Thank you @alflennik for getting those latest 2 fixes included in this PR. |
|
Deployed. I did a just few quick checks, and looks good. Others please do more thorough QA. Thanks. |
|
Thank you @shawna-slh! I confirmed that the support tables are working. |
|
Thank you @shawna-slh!!! I went through all the changed pages since last deploy and spot checked some other places, and from the POV of a screen reader user, it looks great! I hope the same is true visually! |
|
@mcking65 I confirmed that the button indicator is working. |
Hi @shawna-slh, we would like to deploy a new version of APG.
Changes include:
AT support tables on alert, button, link and radio group example pages (example is here, scroll down to the assistive technology support section.)
Tablist Examples: Improve support for magnification aria-practices#2625: Tablist Examples: Improve support for magnification
Combobox Date Picker Example: Change previous and next month and year behavior for dates near end of month aria-practices#2618: Combobox Date Picker Example: Change previous and next month and year behavior for dates near end of month
Carousel Examples: ad note informing authors that aria-rolesdescription uses the language of the page aria-practices#2358: Carousel Examples: ad note informing authors that aria-rolesdescription uses the language of the page