Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JumpTo menu label incorrect on Mac #133

Closed
mcking65 opened this issue May 19, 2022 · 1 comment · Fixed by #131
Closed

JumpTo menu label incorrect on Mac #133

mcking65 opened this issue May 19, 2022 · 1 comment · Fixed by #131
Assignees
@jongund
Labels
browser-dependency bug Something isn't working Infrastructure
Milestone
Q2/2022 APG Site ...

Comments

@mcking65
Copy link
Contributor

The JumpTo hotkey is alt+0. However, when opening APG in Chrome or Safari on Mac, it is announced as command+0.

To reproduce: on a Mac, Open an example page in the 1.2 publication or in the site preview that implements JumpTo: For instance:

Tab to the jumpto button. Note the announcement contains the string "Command+0" instead of "Alt + 0".
@jongund
Copy link
Contributor

jongund commented Jun 15, 2022

Here is a an update to the SkipTo.js script fixes the bug saying command key, it should say option now.

https://github.com/paypal/skipto/tree/dev/v4.2/downloads/js

As per the conversation today, the APG will just switch from using "JumpTo" to using "SkipTo" to eliminate the need to maintain two separate code repositories and make it easier for other people to add the "SkipTo" functionality to their website.

@mcking65 mcking65 transferred this issue from w3c/aria-practices Jun 19, 2022
@mcking65 mcking65 linked a pull request Jun 20, 2022 that will close this issue
replace jumpto.js with skipto.js version 4.2 #131
Merged
mcking65 added a commit that referenced this issue Jun 23, 2022
@jongund @mcking65 @howard-e
replace jumpto.js with skipto.js version 4.2 (pull #131)
f575cd9 
* Correct copyright and license to accurately attribute authorship and source
* Fix #133: skip to menu label incorrect on Mac
* Fix #134: can't scroll to bottom of skip to menu if not fully visible in viewport
* Fix #135: skip to main does not work on Home Page by ensuring target of skip is visible.

Co-authored-by: Matt King <a11yThinker@gmail.com>
Co-authored-by: Howard Edwards <howarde.edwards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
browser-dependency bug Something isn't working Infrastructure
Projects
None yet
Milestone
Q2/2022 APG Site Design and Infra Upd...
Development

Successfully merging a pull request may close this issue.

replace jumpto.js with skipto.js version 4.2 w3c/wai-aria-practices
2 participants
@jongund @mcking65