Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve non-negative-real interoperability (#943). #944

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

skynavga
Copy link
Collaborator

Closes #943.

@skynavga skynavga added this to the CR3 milestone Jul 30, 2018
@skynavga skynavga self-assigned this Jul 30, 2018
@skynavga skynavga requested a review from nigelmegitt July 30, 2018 05:38
@nigelmegitt
Copy link
Contributor

Marking for the agenda, since as per #943 (comment) the deadline for a change like this seems to have passed, even though it is (probably) a good idea. The alternative would be to defer to 2nd Ed.

@css-meeting-bot
Copy link
Member

The Working Group just discussed Improve non-negative-real interoperability (#943). ttml2#944, and agreed to the following:

  • SUMMARY: Close pull request and mark as TTML.next.
The full IRC log of that discussion <nigel> Topic: Improve non-negative-real interoperability (#943). ttml2#944
<nigel> github: https://github.com//pull/944
<nigel> Glenn: I have no problem deferring this to 2nd Ed, and note that if we do that then we
<nigel> .. need to approve #956 in the meantime.
<nigel> Nigel: This is about making the value "0." that is illegal in TTML1 legal by adopting xs:decimal.
<nigel> .. I think we should do nothing and nobody will care.
<nigel> Glenn: If we don't do it then we have to do #956.
<nigel> Nigel: Any other views on this?
<nigel> [group]: silence
<nigel> Glenn: The reason #956 is important is that if we use xs:decimal in our schema then all
<nigel> .. the tools that take the schema will make it impossible to tell if 0. was used because the
<nigel> .. resulting value will be a double floating point number whose original lexical value will
<nigel> .. be lost. Changing it to a string will pass that through to implementations.
<nigel> Nigel: And the XSD is not normative and it is not a requirement for implementers to use it.
<nigel> Glenn: Sure.
<nigel> Nigel: There are no comments on this.
<nigel> Glenn: I will move this issue to TTML.next.
<nigel> Nigel: OK
<nigel> SUMMARY: Close pull request and mark as TTML.next.

@skynavga
Copy link
Collaborator Author

skynavga commented Aug 2, 2018

Deferring to consideration under ttml.next.

@skynavga skynavga closed this Aug 2, 2018
@skynavga skynavga removed their assignment Nov 5, 2018
@skynavga skynavga reopened this Jul 18, 2019
@skynavga skynavga modified the milestones: 1ED-CR3, 2ED-FPWD Jul 18, 2019
@skynavga skynavga self-assigned this Jul 18, 2019
@skynavga skynavga requested a review from palemieux July 18, 2019 15:17
@palemieux
Copy link
Contributor

The pull request is missing tests to exercise the change.

Copy link
Contributor

@nigelmegitt nigelmegitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests at w3c/ttml2-tests#208 look good.

@skynavga skynavga merged commit d8995c4 into master Aug 2, 2019
@skynavga skynavga deleted the issue-0943-non-negative-real branch August 2, 2019 02:42
@skynavga skynavga removed their assignment Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive syntax Changes document syntax. tests Has one or more tests in test suite.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve interoperability of non-negative-real and xs:decimal.
4 participants