-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contextualize 'considered an error' (#1067). #1098
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigelmegitt
reviewed
May 28, 2019
cconcolato
reviewed
May 29, 2019
cconcolato
reviewed
May 29, 2019
cconcolato
reviewed
May 29, 2019
cconcolato
reviewed
May 29, 2019
@skynavga I'd like us to have resolved @cconcolato 's comments before completing my review. |
nigelmegitt
reviewed
Jun 4, 2019
cconcolato
approved these changes
Jun 6, 2019
Merged before the 10 days delay because editorial and agreed in meeting |
The Timed Text Working Group just discussed The full IRC log of that discussion<nigel> Topic: Contextualize 'considered an error' (#1067). ttml2#1098<nigel> github: https://github.com//pull/1098 <cyril> nigel: there are many open parts on this <cyril> ... there are unresolved conversations <cyril> nigel: about TR and RR I pushed that in a separate conversation <plh_> rrsagent, generate minutes <RRSAgent> I have made the request to generate https://www.w3.org/2019/06/06-tt-minutes.html plh_ <plh_> rrsagent, generate minutes <RRSAgent> I have made the request to generate https://www.w3.org/2019/06/06-tt-minutes.html plh_ <nigel> scribe: nigel <nigel> Nigel: We've resolved all the unresolved conversations. <nigel> .. Any objections to merging? <nigel> group: no objections <nigel> Nigel: Ok we can go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1067.