-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add syntax of codecs parameter #78
Conversation
|
The Timed Text Working Group just discussed
The full IRC log of that discussion<nigel> Topic: Add syntax of codecs parameter #78<nigel> github: https://github.com//pull/78 <nigel> Mike: 4 points, a couple are editorial. <nigel> Nigel: My plan for the concrete example was to have a separate pull request. <nigel> Mike: Sure, we should add it though, as we agreed last week. <nigel> Nigel: Yes, no problem. <nigel> Mike: Going through my comments. <nigel> .. I thought it would be good to note that the element in RFC6381 prohibits "." <nigel> .. It's not clear in RFC6381 but you can't add a "." <nigel> Nigel: I wanted only to add a constraint statement and not duplicate what's in 6381. <nigel> .. We could describe 6381 but not redefine it. <nigel> Mike: I think 99% of readers won't go to 6381 so the prohibition of "." is worth calling out in a note. <nigel> .. 2nd one is a bit of rewording. <nigel> Nigel: Good for me. <nigel> Mike: The concrete example using IMSC 1.0.1 and EBU-TT-D 1.0.1 would be valuable. <nigel> .. And the 4th one is something about the formatting. <nigel> Nigel: The formatting looks good to me. <nigel> Cyril: It looks good to me too. <nigel> Nigel: That's weird, I stole the formatting from IMSC to make it look the same. <nigel> Cyril: There's a typo - I'll put a note on the line. <nigel> Nigel: OK sounds like there's a bit of work, but straightforward, thanks for the reviews. <nigel> SUMMARY: @nigelmegitt to do 2nd editorial pass |
I just traced this through, and I don't think "period" is forbidden. The existing text in the TTML Profiles Registry says:
RFC6381 defines
[RFC2045] defines:
By my reading, this means that |
@mikedo @cconcolato I've addressed your review comments; I was left a bit confused by our discussion about the concrete example, since it also appears to be part of the proposal in #76; on balance I think it better addressed by a separate pull request there if that's okay. The formatting problem appears to be an issue only with the HTML diff output, so no change needed there. |
Period is a core delimiter in the 6381 codecs syntax. Element cannot contain a period. See 6381, section 3.4. |
That section does not define Oh hang on, I missed a crucial line two below the definition of
Since we do not want to allow hierarchy delimiters in the midst of identifiers, I agree we need to clarify that the intent for our |
I don't understand the concern, but to remove all doubt about what I propose, please add the following real life examples somewhere: For example, the codecs string for TTML documents that conform to both IMSC1.0.1 text profile and EBU-TT-D-1 (the intersection) would be "im1t|etd1". And for TTML documents that require both IMSC1.0.1 and EBU-TT-D-1 (the union) would be "im1t+etd1". |
OK @mikedo please could you have a look now, I think both remaining comments are addressed. |
Also separate out the encouragement to support from the syntax definition and explanation as per discussion at #71.
323193f
to
a88760d
Compare
Also separate out the encouragement to support from the syntax definition and explanation as per discussion at #71 (comment), and add a note about MP4's
codecs
parameter.Resolves #71.
Preview | Diff