Add workerStart attribute to measure SW startup #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- optional attribute because SW support is not (yet) universal - missing registration results in zero value (i.e. SW not used) - set to time when worker is run or fetch is fired at worker
Unnecessary restriction and application cache check is covered by the "fetching process" algorithm already.
|
LGTM |
|
In general, it's a bad idea to have optional features imho. We did make secureConnectionStart optional in nav timing and I don't believe it served anyone. If SW isn't used or supported, it should return 0 imho. |
|
LGTM++ |
igrigorik
added a commit
that referenced
this pull request
Apr 3, 2015
Add workerStart attribute to measure SW startup
igrigorik
added a commit
to w3c/navigation-timing
that referenced
this pull request
Apr 3, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11.
@slightlyoff could you sanity check the wording around active workers and matching registrations? Does that look sane?
@plehegar I've removed the HTTP GET clause in processing because its unnecessarily restrictive (SW sees all fetches regardless of the HTTP verb). Let me know if this is an issue... it seems like a bug in current spec - e.g. it would imply that POST'ed XHRs are not reported within RT.