-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify li element role allowances #410
Conversation
cc @stevefaulkner @patrickhlauke please review |
- fix typo - clarify role rules further
what about |
I support allowing
I lean against allowing
|
Or if we want the rules to be more opinionated (in the software sense), say one of the following:
|
that seems reasonable on its surface, but would make the implementation of the rule more complicated. practically one could do re:
if that were actually allowed by ARIA/HTML, then it would be a reasonable allowance. Separately I have tested the current reality of how that works with AT, and while it causes some minor breakages depending on the browser/at combo, I have requested that become an allowance in HTML, which would then make it allowed in ARIA, and subsequently this spec. Until then though, there will be no change here on that matter. |
I'm convinced. Thanks for the clear explanation. |
Closes #351
This change is to clarify that if an
li
is a child of aul
,ol
, ormenu
element, and those elements are exposed as alist
, then no other role can be specified on theli
.However, if the parent of the
li
is no longer exposed as alist
, or if someone were to write invalid markup and use anli
outside of the expected list > listitem markup pattern, then any role should be allowed on theli
(so long as the role is a role allowed by theli
's parent element)For instance,
is not be allowed as a
button
cannot be a direct child of atable
. However, but arole=row
on theli
would be allowed in this example.and
is invalid HTML, but as the
li
is not a child of a list element, it should be allowed to have any role.test cases
Preview | Diff