Change default allowlist to 'all' #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
approved these changes
Nov 12, 2021
|
Linked Webkit bug... I'll see if I can quickly add it. |
|
I... think the tests were actually testing |
4 tasks
|
Actually, I think the tests expect that cross-origin access will be blocked by default. I uploaded a fix: https://crrev.com/c/3566254 |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 2, 2022
The Gamepad API spec is updated to change the default allowlist for the "gamepad" permissions policy to '*' (all) instead of 'self'. w3c/gamepad#156 Change-Id: I087b3f77eebb385d2e2b80c0a19f5f3afedda30e
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 4, 2022
The Gamepad API spec is updated to change the default allowlist for the "gamepad" permissions policy to '*' (all) instead of 'self'. w3c/gamepad#156 Change-Id: I087b3f77eebb385d2e2b80c0a19f5f3afedda30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3566254 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#988606}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 4, 2022
The Gamepad API spec is updated to change the default allowlist for the "gamepad" permissions policy to '*' (all) instead of 'self'. w3c/gamepad#156 Change-Id: I087b3f77eebb385d2e2b80c0a19f5f3afedda30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3566254 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#988606}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Apr 4, 2022
The Gamepad API spec is updated to change the default allowlist for the "gamepad" permissions policy to '*' (all) instead of 'self'. w3c/gamepad#156 Change-Id: I087b3f77eebb385d2e2b80c0a19f5f3afedda30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3566254 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#988606}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Apr 11, 2022
… to 'all' #156", a=testonly Automatic update from web-platform-tests Update WPT for "Change default allowlist to 'all' #156" The Gamepad API spec is updated to change the default allowlist for the "gamepad" permissions policy to '*' (all) instead of 'self'. w3c/gamepad#156 Change-Id: I087b3f77eebb385d2e2b80c0a19f5f3afedda30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3566254 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#988606} -- wpt-commits: 8986d0b7443dee8302ea58ef2e0d97fd7163dfde wpt-pr: 33483
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Apr 14, 2022
… to 'all' #156", a=testonly Automatic update from web-platform-tests Update WPT for "Change default allowlist to 'all' #156" The Gamepad API spec is updated to change the default allowlist for the "gamepad" permissions policy to '*' (all) instead of 'self'. w3c/gamepad#156 Change-Id: I087b3f77eebb385d2e2b80c0a19f5f3afedda30e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3566254 Reviewed-by: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/main@{#988606} -- wpt-commits: 8986d0b7443dee8302ea58ef2e0d97fd7163dfde wpt-pr: 33483
webkit-commit-queue
pushed a commit
to marcoscaceres/WebKit
that referenced
this pull request
Dec 18, 2023
https://bugs.webkit.org/show_bug.cgi?id=230136 rdar://83219098 Reviewed by Youenn Fablet. Implements "gampad" permission policy defaulting to '*' for the allow list. This matches Chrome's behavior and is also what's intended to go into the spec: w3c/gamepad#156 * LayoutTests/http/tests/gamepad/gamepad-allow-attribute.https-expected.txt: Added. * LayoutTests/http/tests/gamepad/gamepad-allow-attribute.https.html: Added. * LayoutTests/http/tests/gamepad/resources/gamepad-postmessage.html: Added. * Source/WebCore/Modules/gamepad/NavigatorGamepad.cpp: (WebCore::NavigatorGamepad::getGamepads): Deleted. * Source/WebCore/Modules/gamepad/NavigatorGamepad.h: * Source/WebCore/html/FeaturePolicy.cpp: (WebCore::policyTypeName): (WebCore::processOriginItem): (WebCore::FeaturePolicy::parse): (WebCore::FeaturePolicy::allows const): * Source/WebCore/html/FeaturePolicy.h: Canonical link: https://commits.webkit.org/272199@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155
The following tasks have been completed:
Implementation commitment:
Preview | Diff
Preview | Diff