Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#271: Moved SPARQL definitions from Core into an appendix of SHACL-SPARQL #294

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

HolgerKnublauch
Copy link
Contributor

No description provided.

Copy link
Contributor

@bergos bergos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Four definitions are missing in the SPARQL Extensions spec:

  • sh:targetNode
  • sh:minInclusive
  • sh:maxExclusive
  • sh:maxInclusive

@HolgerKnublauch
Copy link
Contributor Author

@bergos the three constraints are listed under sh:minExclusive because they are all so similar.
sh:targetNode cannot be expressed in SPARQL anymore because they may be node expressions now.

@bergos
Copy link
Contributor

bergos commented Mar 3, 2025

@HolgerKnublauch Sorry, I missed the min/max when comparing "POTENTIAL DEFINITION IN SPARQL" count for completeness.

Depending on where we allow node expressions, also others could no longer be directly expressed in SPARQL. e.g., $minExclusive must be substituted with / bound to the result of the evaluated node expression in case a node expression is given as the value.

@HolgerKnublauch
Copy link
Contributor Author

Depending on where we allow node expressions, also others could no longer be directly expressed in SPARQL. e.g., $minExclusive must be substituted with / bound to the result of the evaluated node expression in case a node expression is given as the value.

Yes, good point. I have added a TODO note for this, as Core is not quite there yet either.

@HolgerKnublauch HolgerKnublauch requested a review from bergos March 4, 2025 07:40
@HolgerKnublauch HolgerKnublauch merged commit 98aaa20 into gh-pages Mar 5, 2025
1 check passed
@HolgerKnublauch HolgerKnublauch deleted the issue-271-move-sparql-definitions branch March 5, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants