[css-view-transitions-2] Apply new @view-transition rule syntax #9523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the `@view-transition { navigation: auto | none; type: ... }` syntax as per the resolution
- `type: none` means that type is unspecified, needs a resolution
- reloads are ignored as per previous resolution
- Renamed the JS param "type" instead of "types"
- Currently types are resolved both at old and new document
separately, this needs a resolution.
Closes w3c#9383
See resolution: w3c#9383 (comment)
|
cc @bokand |
vmpstr
reviewed
Oct 26, 2023
vmpstr
approved these changes
Oct 26, 2023
|
|
||
| 1. Set |document|'s [=document/ready to render fired=] to true. | ||
| 1. If |matchingRule| contains a ''@view-transition/type'' descriptor, then return a [=list=] of strings corresponding to that descriptor's [=computed value=]. |
There was a problem hiding this comment.
Yes, though there is no way to specify an empty list.
|
|
||
| 1. Let |transition| be the result of getting the [=inbound cross-document view-transition=] for |document|. | ||
| 1. [=Fire an event=] named <code>pagereveal</code> at |document|'s [=relevant global object=], | ||
| using {{PageRevealEvent}}, with [=PageRevealEvent/view transition=] initialized to . |
There was a problem hiding this comment.
I think you meant "initialized to the [=inbound cross-document view-transition=]".
There was a problem hiding this comment.
Oops, should be |transition|. Will follow up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@view-transition { navigation: auto | none; type: ... }syntax as per the resolutiontype: nonemeans that type is unspecified, needs a resolutionCloses #9383
See resolution: #9383 (comment)