-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[selectors-4] clarify when :volume-locked matches #8061
Comments
Can you clarify what part was confusing? Is it the first bit (shared with the :muted pseudo, so we should rephrase both) or just the second part? |
What's confusing with the current wording is the: "capable of making sound when programmatically changing the element’s volume...". Maybe something like:
Or... "...where attempting to change the effective media volume through an API has no effect. This is because it's is locked by either the underlying operating system or a user preference." ... and maybe needs a note about accessibility? |
Perhaps the minimal clarification that would help explain why the current wording says what it says would be to add a comma:
But I agree that some of the other clarifications proposed above would be helpful. |
@tabatkins, THB, I actually didn't follow the link to "effective media volume" on my first reading, I just knew this wasn't a "native" concept to HTML media elements, and couldn't recognize a situation where changing the volume doesn't work. @lilles helped find Intent to Implement and Ship: Implement :playing, :paused pseudo-classes, it turns out part of this was implemented in Blink, but wasn't shipped because the HTML integration doesn't exist. Defining this in https://html.spec.whatwg.org/#pseudo-classes would be an even better fix. |
I tend to agree (in addition to modifying the language a bit too). |
Ah yeah that sentence is really too complex to go without a comma, at minimum, separating the first half from the second. Absolutely reasonable to have trouble parsing it as-is. I've just rephrased them both, does the new text work better for you?
|
The above seems good/clear to me at least 👍. Over to @foolip. |
That wording looks good to me! Is it going to be normative or not though? If we define selector matching in https://html.spec.whatwg.org/#pseudo-classes, that would need to take precedence, but if both claim to be normative it's at minimum redundant. |
Well, both of the parentheticals just say "see X", without any further clarification of what we're supposed to see or what effect it might have, so they're not making any normative statement at all. The stuff outside the parenthetical is normative and should be consistent with any future changes to HTML. |
https://w3c.github.io/csswg-drafts/selectors-4/#sound-state defines the
:volume-locked
pseudo-class as:I wasn't able to parse what this means, and found in web-platform-tests/interop#224 (comment) that there aren't any tests to give clues either.
The answer can be found in #3933 (comment), and it would be great if it was spelled out in the spec that this is about the first step of the definition in HTML:
The text was updated successfully, but these errors were encountered: