Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-color-4] Defer @color-profile to L5 #6765

Closed
LeaVerou opened this issue Oct 26, 2021 · 14 comments
Closed

[css-color-4] Defer @color-profile to L5 #6765

LeaVerou opened this issue Oct 26, 2021 · 14 comments
Assignees
@LeaVerou @svgeesus
Labels
css-color-4 Current Work css-color-5 Color modification

Comments

@LeaVerou
Copy link
Member

Unlike the other color formats in Color 4, custom color spaces (@color-profile) have far less implementor interest, but still complicate a lot of our discussions and hold the spec back.

@svgeesus and I think we should defer this functionality to Level 5. Agenda+ for group resolution.
@LeaVerou LeaVerou added css-color-4 Current Work Agenda+ css-color-5 Color modification labels Oct 26, 2021
@svgeesus svgeesus mentioned this issue Oct 26, 2021
Open
@tabatkins
Copy link
Member

Only significant issue with punting is that it means we're back to device-cmyk() having no way to resolve intelligently; at level 4 we'd have to mandate it resolves in a UA-specific manner, using the naive conversion rules unless the UA has reason to do something different for the user.

@LeaVerou
Copy link
Member Author

Only significant issue with punting is that it means we're back to device-cmyk() having no way to resolve intelligently; at level 4 we'd have to mandate it resolves in a UA-specific manner, using the naive conversion rules unless the UA has reason to do something different for the user.

What prevents us from punting that as well?

@tabatkins
Copy link
Member

Punting the entire function? Allowed, I suppose, but I thought it had implementations.

@LeaVerou
Copy link
Member Author

LeaVerou commented Nov 1, 2021

Punting the entire function? Allowed, I suppose, but I thought it had implementations.

Not in browsers AFAIK, but possibly in print formatters.

@faceless2
Copy link

faceless2 commented Nov 10, 2021 •
edited
Loading

FWIW it makes no difference to us which level device-cmyk is in, or @color-profile.

All other print formatters already have existing (non-standard) cmyk functions, so I'm presuming that the drive to add device-cmyk to those is going to be a desire for compat once this is implemented in browsers.

@svgeesus
Copy link
Contributor

svgeesus commented Nov 10, 2021 •
edited
Loading

A quick device-cmyk test fails in Safari 15, Firefox 95 and Chrome 97, and passes in BFO Publisher.

<!DOCTYPE html>
<style>.test {
  background: red;
  width: 10em;
  height: 10em
}
@supports (color: device-cmyk(0.1 0.2 0.3 0.4)) {
  .test {
    background: device-cmyk(100% 0% 100% 50%)
  }
}</style>
<div class="test"></div>

@svgeesus
Copy link
Contributor

The Inkscape documentation seems very out of date (2017, with lots of "not updated for version 0.91") but from what I can see it does not implement device-cmyk or color() (and thus, not @color-profile either).

@css-meeting-bot
Copy link
Member

The CSS Working Group just discussed @color-profile to L5, and agreed to the following:

  • RESOLVED: Move @color-profile and device-cmyk() to L5
The full IRC log of that discussion <fantasai> Topic: @color-profile to L5
<fantasai> github: https://github.com//issues/6765
<fantasai> lea: Custom color spaces have not gotten same implementer interest of other features in L4
<fantasai> lea: and complicate a lot of discussoins due to custom color spaces
<fantasai> lea: also had some ideas that depend on L5 features
<TabAtkins> q+
<fantasai> lea: so suggestion is to defer to L5
<fantasai> lea: but Tab raised that device-cmyl() depends on it
<fantasai> lea: which is implemented only in print impls
<fantasai> lea: Suggest is to also defer device-cmyk()
<chris_> q+
<fantasai> TabAtkins: I agree with this, and there's a lot of interesting things to work on here
<Rossen_> ack TabAtkins
<fantasai> TabAtkins: that could use time to bake without holding up L4
<fantasai> chris_: I also agree
<Rossen_> ack chris_
<fantasai> chris_: also have some feedback, have a descriptor called 'components' that doesn't appear to do anything because what it affects is in L5, so another reason to move
<fantasai> Rossen_: so proposed to move @color-profile and device-cmyk() to L5
<fantasai> RESOLVED: Move @color-profile and device-cmyk() to L5

@mozilla-apprentice mozilla-apprentice mentioned this issue Nov 10, 2021
Closed
svgeesus added a commit that referenced this issue Nov 11, 2021
@svgeesus
[css-color-5] Move @color-profile and device-cmyk to L5, see #6765
0290aaf
svgeesus added a commit that referenced this issue Nov 11, 2021
@svgeesus
[css-color-4] Remove @color-profile and device-cmyk, see #6765
055ba4c
svgeesus added a commit that referenced this issue Nov 11, 2021
@svgeesus
[css-color] Move device-cmyk to stylesheet in L5, see #6765
be8a8a4
svgeesus added a commit that referenced this issue Nov 11, 2021
@svgeesus
[css-color] Move resolving & serializing of custom color and device-c…
41c4a66 
…myk to L5, see #6765
@GPHemsley
Copy link

@svgeesus <color> still mentions <device-cmyk()> (with a link to css-color-5). The introduction and the definition of "rectangular orthogonal color" also still mention CMYK/KCMYGOV/CMYKOGV. Is that intentional, or an oversight?

@LeaVerou
Copy link
Member Author

LeaVerou commented Oct 1, 2022

@svgeesus <color> still mentions <device-cmyk()> (with a link to css-color-5). The introduction and the definition of "rectangular orthogonal color" also still mention CMYK/KCMYGOV/CMYKOGV. Is that intentional, or an oversight?

Oversight.

svgeesus added a commit that referenced this issue Oct 3, 2022
@svgeesus
[css-color-4] Remove dangling reference to CMYKOGV), #6765
5d35584
@svgeesus
Copy link
Contributor

svgeesus commented Oct 3, 2022

Already fixed in the Editors Draft: introduction and fixed just now in definition of rectangular orthogonal color

@GPHemsley
Copy link

GPHemsley commented Oct 4, 2022 •
edited
Loading

Already fixed in the Editors Draft: introduction and fixed just now in definition of rectangular orthogonal color

I take it you've noticed the usual editor's draft links are currently MIA? 😄

@LeaVerou
Copy link
Member Author

LeaVerou commented Oct 4, 2022

Already fixed in the Editors Draft: introduction and fixed just now in definition of rectangular orthogonal color

I take it you've noticed the usual editor's draft links are currently MIA? 😄

Pinned issue: #6528

@svgeesus
Copy link
Contributor

svgeesus commented Oct 4, 2022

I take it you've noticed the usual editor's draft links are currently MIA?

They have been intermittently broken for over a year. That is why I linked to an alternative (and reliable) location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeaVerou LeaVerou

@svgeesus svgeesus

Labels
css-color-4 Current Work css-color-5 Color modification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@LeaVerou @GPHemsley @tabatkins @faceless2 @svgeesus @css-meeting-bot