[accname PR 235] feat: update step 2F to exclude nodes referenced by aria-actions #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
8 tasks
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aleventhal
reviewed
Oct 14, 2024
| @@ -671,6 +671,13 @@ <h4>Computation steps</h4> | |||
| <span id="step2F.iii"><!-- Don't link to this legacy numbered ID. --></span><em>Name From Each Child:</em> For each <code>rendered child node</code> of the | |||
| <code>current node</code>: | |||
| <ol> | |||
| <li id="comp_name_from_content_find_child_actions"> | |||
There was a problem hiding this comment.
Do we need to say both of these things? They seem like they're essentially saying the same as each other.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Dec 4, 2024
If the name of an element with aria-actions is computed via `name from contents`, it should not contain the contents of the target actions. This way, buttons/links/etc don't pollute the accessible name. w3c/aria#2208 Change-Id: I0d5ebf7dbdf163796aba98dfb4a90ddf6cb2e7db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6038804 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391669}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from w3c/accname#235