Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range should subclass structure rather than widget #892

Closed
joanmarie opened this issue Jan 24, 2019 · 1 comment
Closed

Range should subclass structure rather than widget #892

joanmarie opened this issue Jan 24, 2019 · 1 comment
Assignees
@joanmarie
Milestone
ARIA 1.2

Comments

@joanmarie
Copy link
Contributor

In working on the new meter role, I had it subclass range. The problem with that is range subclasses widget and a widget is interactive.

The general consensus from the Working Group's meeting today is that range should subclass structure. Then the interactive roles which subclass range should also subclass widget.
@joanmarie joanmarie self-assigned this Jan 24, 2019
@joanmarie joanmarie added this to the ARIA 1.2 milestone Jan 24, 2019
@joanmarie joanmarie mentioned this issue Jan 24, 2019
Closed
@joanmarie
Copy link
Contributor Author

Regarding the interactive roles, it turns out that slider and spinbutton already subclass both range and input. And, of course, input subclasses widget. So it's only progressbar and scrollbar whose parent class need to be changed.

joanmarie added a commit that referenced this issue Jan 30, 2019
@joanmarie
Change the subclass of range from widget to structure
3ff5955 
This is needed to support the aria-value* attributes on non-interative,
and potentially static objects such as a meter.

Because range now subclasses structure, we need to use multiple inheritance
with the widget roles which subclass range. Those roles are: progressbar,
scrollbar, slider, and spinbutton. The latter two already subclass both range
and input thus no further change is needed. Progressbar and scrollbar now
subclass both range and widget.

Addresses github issue #892.
@joanmarie joanmarie mentioned this issue Jan 30, 2019
Merged
@joanmarie joanmarie removed the Agenda label Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joanmarie joanmarie

Labels
None yet
Projects
None yet
Milestone
ARIA 1.2
Development

No branches or pull requests
2 participants
@jnurthen @joanmarie