Radio Group Pattern: Add new keyboard interaction for radios in toolbars #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For issue #949, modified the radio group pattern section aria-practices.html: * Divided the keyboard interaction subsection into two subsections: not in toolbar and in toolbar. * Added interactions for the special case of radios contained in toolbars.
|
I think it looks good, but we I think we also need to define behavior of the up and down arrow keys in the toolbar case. The up and down arrow keys could be defined only allowing navigation within the radio buttons in the current radio group and could also have the selected radio to follow focus. The current toolbar example provides most of this up and down arrow functionality, it could be modified for the selected radio button to follow focus. Also do we need to provide any guidance on the use of the ENTER key, since it usually is the keyboard behavior for activating the default action of buttons? |
Per feedback from @charmarkk in issue #949, revise left and right arrow descriptions for clarity. Changed to bulleted list of behaviors for each key. Per feedback from @jongund on the aria-practices list serve, added guidance for enter, up, and down keys.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #949, modified the radio group pattern section aria-practices.html:
Go to section 3.16 in the feature branch to see the changes.
Preview | Diff