552 fix #583
Closed
552 fix #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on discussion with Evan and other members of the task force in the February 5, 2018 meeting, closing this PR with a decision not to fix issue #552. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #552, as recommended by @erikkroes.
To test with a keyboard: open a dialog, move focus to a non-editable element, and press ctrl-a to select all. Inspect the contents of that selection.
While this does technically disable user-selection when a dialog is active, it also adds coupling to the HTML structure outside of the dialog, which concerns me. Specifically, prior to this PR, dialogs operated as standalone units that didn't affect other elements on the page. With this PR,
user-select: none;needs to be applied to everything that we don't want to be selected. That's just the#base_window_layerhere, but that's only a coincidence of how the HTML is structured.The only other alternative I can imagine would be messing about with selection listeners, and I don't like that very much either.
I'd be okay with delaying this or not merging it.